Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
I ran into a problem when setting the
cookieDomain
option in the session config. The cookie is set correctly when logging in, but because the domain is missing when clearing the cookie in the logout handler it seems that the cookie is not cleared and I remain logged in. Although if I try logging in again Auth0 presents me with the login page.It looks like an easy fix to add the
cookieDomain
when clearing the cookie, but I'm not sure if this is the right approach.Testing
Checklist
master