Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-3434] Update issues templates #140

Merged
merged 13 commits into from
Jun 16, 2022
Merged

[SDK-3434] Update issues templates #140

merged 13 commits into from
Jun 16, 2022

Conversation

evansims
Copy link
Member

@evansims evansims commented Jun 16, 2022 •
edited
Loading

Changes

This PR updates the GitHub issue templates for the repository, and applies the new GitHub issue forms YML format to Bug Reports and Feature Requests.

References

See internal ticket SDK-3434 for reference.

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If helpful, please include manual testing steps as well.

  • This change adds unit test coverage (or why not)
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@evansims evansims changed the base branch from master to fa June 16, 2022 03:03
@evansims
Copy link
Member Author

@Widcket 👋

  • I targeted fa with this PR as this is the development branch you've been targeting. Please let me know if this should be pointing to master instead, and I'll create a fresh PR with these changes to target that.
  • I know SDK-3434 mentioned pointing to /jwt for Community links; however, I assume /ios would be more appropriate for this particular library? Please let me know if I'm wrong, and I can change that.

@evansims evansims marked this pull request as ready for review June 16, 2022 03:07
@evansims evansims requested a review from a team as a code owner June 16, 2022 03:07
@evansims evansims added the review:small Small review label Jun 16, 2022
Widcket
Widcket approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@Widcket Widcket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, great work! Just left a couple of comments about moving the Code of Conduct checkbox to the checklist at the top.
Also, please include the PR template from Auth0.swift (see SDK-3434).

Widcket
Widcket requested changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@Widcket Widcket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, approved by mistake 🤦🏼‍♀️

@evansims
Copy link
Member Author

@Widcket No problem, and thanks for your edits! I've updated with your feedback 👍

@evansims evansims requested a review from Widcket June 16, 2022 18:03
Widcket
Widcket approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@Widcket Widcket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Widcket Widcket merged commit e0c45a7 into fa Jun 16, 2022
@Widcket Widcket deleted the update-pull-request-template branch June 16, 2022 18:23
Widcket added a commit that referenced this pull request Jul 20, 2022
@Widcket @evansims
Merge fa into master (#167)
5db89fd 
* Add migration guide [SDK-3393] (#127)

Add migration guide

* Remove license header from source files [SDK-3389] (#126)

Remove license header

* Update year in license file (#128)

* Add `.swiftpm` directory to `.gitignore` (#131)

Add `.swiftpm` to `.gitignore`

* Add CONTRIBUTING.md (#130)

* Drop old platform versions [SDK-3387] (#129)

* Drop old platform versions

* Remove preprocessor macros and compatibility code

* Remove obsolete preprocessor macros

* Use accesibility config when neither iOS nor macOS

* Remove unnecessary preprocessor macros

* Remove extra blank line at the end of the file

* Restore Touch ID case

* Remove leftover nested if

* Update README [SDK-3416] (#135)

* Remove deprecated method [SDK-3413] (#132)

* Remove deprecated method

* Add change to the migration guide

* Remove usage of deprecated properties [SDK-3414] (#133)

* Remove usage of deprecated APIs

* Remove enum cases

* Remove usage of enum cases

* Update V1_MIGRATION_GUIDE.md

Co-authored-by: Steve Hobbs <steve.hobbs@auth0.com>

Co-authored-by: Steve Hobbs <steve.hobbs@auth0.com>

* Add support policy [SDK-3420] (#138)

* Fix typo in property name (#137)

* Remove obsolete functionality [SDK-3419] (#136)

* [SDK-3434] Update issues templates (#140)

* [SDK-3434] Migrate GitHub issue templates

* Update config.yml

* Update config.yml

* Add note about the Responsible Disclosure Program to bug reports template.

* Remove "FAQ.md" reference, as there is no file

* Update .github/ISSUE_TEMPLATE/Bug Report.yml

* Update .github/ISSUE_TEMPLATE/Feature Request.yml

* Update .github/ISSUE_TEMPLATE/Bug Report.yml

* Update .github/ISSUE_TEMPLATE/Feature Request.yml

* Update .github/ISSUE_TEMPLATE/config.yml

* Update .github/ISSUE_TEMPLATE/config.yml

* Update checkbox grouping

* Update Pull Request template

Co-authored-by: Rita Zerrizuela <zeta@widcket.com>

* Migrate to Swift [SDK-3428] (#139)

* Migrate to Swift

* Add test case

* Integrate SwiftLint

* Add .swiftlint.yml

* Fix tests

* Add API docs

* Update migration guide

* Remove leftover comments

* Update library description

* Add snippets to the API docs

* Drop Xcode 12.x and its older simulators

* Add item to the migration guide

* Drop support for old Swift versions [SDK-3444] (#141)

* Add missing unit tests (#142)

* Add missing tests

* Remove extra whitespace

* Add missing import for SPM

* Apply recommended Xcode 14 settings (#143)

* [SDK-3450] API Documentation Generation (#144)

* Add generated API documentation to repo (#145)

* Add support for iCloud synchronization (#146)

* Add support for iCould synchronization

* Update API docs

* Add unit tests for queries (#147)

Test queries

* Improve API docs generation (#148)

* Fix typos in tests (#149)

* Make `context` parameter optional (#151)

* Re-generate API docs (#152)

* Complete README and Migration Guide [SDK-3397] (#150)

* Add support for custom attributes (#153)

* Replace OSX with macOS in schemes and targets (#154)

Replace OSX with macOS

* Release 1.0.0-fa.0 (#155)

* Add fa to Podspec version (#156)

* Fix 'access group' capitalization (#158)

* Update API docs (#159)

* Use Codecov orb (#161)

* Create .semgrepignore

* Add placeholders to issue forms (#162)

* Update README for GA [SDK-3500] (#163)

Update the README for GA

* Merge `master` into `fa` (#164)

Co-authored-by: Steve Hobbs <steve.hobbs@auth0.com>
Co-authored-by: Evan Sims <evan.sims@auth0.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Widcket Widcket Widcket approved these changes

Assignees
No one assigned
Labels
review:small Small review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evansims @Widcket