Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Mac Catalyst warnings related to deprecated accessibility options #105

Merged
merged 2 commits into from
Feb 1, 2021
Merged

Conversation

eaceto
Copy link
Contributor

@eaceto eaceto commented Jan 15, 2021

Changes

  • kSecAttrAccessibleAlways and kSecAttrAccessibleAlwaysThisDeviceOnly are deprecated on Mac Catalyst due to the fact that does not provide a useful level of protection. They should be replaced with kSecAttrAccessibleAfterFirstUnlock and kSecAttrAccessibleAfterFirstUnlockThisDeviceOnly respectively

References

Testing

[X] Tested on a Mac Catalyst application, this removed the warnings sent by the compiler and still provides a secure storage.

Checklist

[X] I have read the Auth0 general contribution guidelines

[X] I have read the Auth0 Code of Conduct

[X] All existing and new tests complete without errors

@eaceto eaceto requested a review from a team as a code owner January 15, 2021 12:36
@eaceto eaceto changed the title Strengthen security and removed deprecations on Mac Catalyst Strengthen security and remove deprecations on Mac Catalyst Jan 15, 2021
@cocojoe cocojoe merged commit ab2e630 into auth0:master Feb 1, 2021
@eaceto
Copy link
Contributor Author

eaceto commented Feb 1, 2021

Thanks @Widcket and @cocojoe .

I found some other warnings and issues, I will be uploading a new MR later about it.

@Widcket Widcket added this to the vNext milestone Feb 2, 2021
@Widcket Widcket changed the title Strengthen security and remove deprecations on Mac Catalyst Fixed Mac Catalyst warnings related to deprecated accessibility options Feb 12, 2021
@Widcket Widcket mentioned this pull request Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants