Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate resumeAuth and useLegacyAuthentication #514

Merged
merged 1 commit into from
Oct 11, 2021
Merged

Deprecate resumeAuth and useLegacyAuthentication #514

merged 1 commit into from
Oct 11, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Oct 8, 2021 •
edited
Loading

Changes

This PR deprecates two iOS-only methods in preparation for the next major:

  • resumeAuth: is not needed when targeting iOS 11+, and the next major will require a minimum of iOS 12.
  • useLegacyAuthentication: makes the SDK use SFSafariViewController instead of ASWebAuthenticationSession. The next major will only use ASWebAuthenticationSession.

Testing

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@Widcket Widcket requested a review from a team as a code owner October 8, 2021 01:52
@Widcket Widcket changed the title Deprecate iOS methods Deprecate resumeAuth and useLegacyAuthentication Oct 8, 2021
@Widcket Widcket merged commit 0e525fe into master Oct 11, 2021
@Widcket Widcket deleted the chore/ios-deprecations branch October 11, 2021 13:35
Widcket added a commit that referenced this pull request Oct 12, 2021
@Widcket
Update CHANGELOG.md with #514
b699f66
@Widcket Widcket mentioned this pull request Oct 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbalmaceda lbalmaceda lbalmaceda approved these changes

Assignees
No one assigned
Labels
CH: Deprecated review:tiny Tiny review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Widcket @lbalmaceda