Skip to content
This repository has been archived by the owner on Jul 31, 2021. It is now read-only.

fix: error for extra url when importing change_password #98

Merged
merged 1 commit into from
Jul 6, 2020

Conversation

pmalouin
Copy link
Contributor

@pmalouin pmalouin commented Jul 6, 2020

✏️ Changes

Fixes: auth0/auth0-deploy-cli#255 (introduced by #95 in release v4.1.0)

To reproduce:

  • Install deploy-cli to latest version. Make sure that it installs the auth0-source-control-extension-tools to version 4.1.0 (released on July 2nd).
  • Ensure your tenant has a custom change_password page.
  • Export tenant settings
  • Try to re-import tenant settings.

Error:

2020-07-06T18:08:20.319Z - error: Problem running command import during stage processChanges when processing type pages
2020-07-06T18:08:20.320Z - error: Payload validation error: 'Additional properties not allowed: url' on property change_password (Change Password page customization).

Explanation: the default value set for the url attribute in the JSON schema causes the validation logic to always add a url attribute set to "" on all pages, even on the change_password page that does not support this attribute (only the error_page supports it).

📷 Screenshots

🔗 References

Error report: auth0/auth0-deploy-cli#255

🎯 Testing

🚫 This change has been tested in a Webtask

✅ This change has been tested using a local installation of Deploy CLI

🚫 This change has unit test coverage

🚫 This change has integration test coverage

🚫 This change has been tested for performance

🚀 Deployment

✅ This can be deployed any time

🖥 Appliance

Note to reviewers: ensure that this change is compatible with the Appliance.

@codeclimate
Copy link

codeclimate bot commented Jul 6, 2020

Code Climate has analyzed commit bd5f683 and detected 0 issues on this pull request.

View more on Code Climate.

@shawnmclean shawnmclean merged commit 8dbcc8a into auth0-extensions:master Jul 6, 2020
@pmalouin pmalouin deleted the fix-pages-import branch July 6, 2020 18:51
@yuvalic
Copy link

yuvalic commented Jul 7, 2020

@shawnmclean when it will be released? i really need this feature, its part of my CI to auth0

@pmalouin
Copy link
Contributor Author

pmalouin commented Jul 7, 2020

@yuvalic

when it will be released? i really need this feature, its part of my CI to auth0

We're preparing the release for today. Sorry for the delay.

@pmalouin
Copy link
Contributor Author

pmalouin commented Jul 7, 2020

@yuvalic The fix has be released as part of 4.1.1: /~https://github.com/auth0-extensions/auth0-source-control-extension-tools/releases/tag/v4.1.1. Please re-install the auth0-deploy-cli and it will automatically pull the patched version of auth0-source-control-extensions.

We're sorry for the inconvenience 🙏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

version 5.0.0 fails on directory import with Payload validation error
3 participants