This repository has been archived by the owner on Jul 31, 2021. It is now read-only.
fix: error for extra url
when importing change_password
#98
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✏️ Changes
Fixes: auth0/auth0-deploy-cli#255 (introduced by #95 in release v4.1.0)
To reproduce:
change_password
page.Error:
Explanation: the
default
value set for theurl
attribute in the JSON schema causes the validation logic to always add aurl
attribute set to""
on all pages, even on thechange_password
page that does not support this attribute (only theerror_page
supports it).📷 Screenshots
⛔
🔗 References
Error report: auth0/auth0-deploy-cli#255
🎯 Testing
🚫 This change has been tested in a Webtask
✅ This change has been tested using a local installation of Deploy CLI
🚫 This change has unit test coverage
🚫 This change has integration test coverage
🚫 This change has been tested for performance
🚀 Deployment
✅ This can be deployed any time
🖥 Appliance
Note to reviewers: ensure that this change is compatible with the Appliance.