[red-knot] Add verbosity argument to CLI #12404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
force-pushed
the
red-knot-cli-verbosity
branch
from
dd4ca90 to
3ab6712
Compare
MichaReiser
force-pushed
the
red-knot-cli-verbosity
branch
from
3ab6712 to
3bd767a
Compare
MichaReiser
commented
Jul 19, 2024
| orchestrator_sender: crossbeam_channel::Sender<OrchestratorMessage>, | ||
| main_loop_receiver: crossbeam_channel::Receiver<MainLoopMessage>, | ||
| verbosity: Option<VerbosityLevel>, | ||
| orchestrator: crossbeam_channel::Sender<OrchestratorMessage>, |
There was a problem hiding this comment.
Sorry for the renames but clippy became very angry at me and told me that the old name was a bad name.
|
It looks a litle odd right now that
|
AlexWaygood
reviewed
Jul 19, 2024
|
AlexWaygood
reviewed
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new
--verboseand-v,-vvand-vvvoptions and uses the level to configure the tracing verbosity.Test Plan
I ran red knot with the different settings and verified that traces appear according to that level.