Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove rules_docker dependency #512

Merged
merged 4 commits into from
Jan 27, 2025
Merged

refactor: remove rules_docker dependency #512

merged 4 commits into from
Jan 27, 2025

Conversation

alexeagle
Copy link
Member

@alexeagle alexeagle commented Jan 25, 2025

It was only here for a container test, but we have replaced this functionality with py_image_layer which is based on rules_oci.

  • Merge the code of containers/ example with the py_image_layer example
  • Test it as an actual OCI image, rather than just a golden test of the archive listing
  • remove the "manual" tag from the container_structure_test

Pre-factoring for switching to bzlmod; we don't want to try loading rules_docker from MODULE.bazel


Changes are visible to end-users: no

Test plan

  • Covered by existing test cases

It was only here for a container test, but we have replaced this functionality with py_image_layer which is based on rules_oci.

Pre-factoring for switching to bzlmod; we don't want to try loading rules_docker from MODULE.bazel
@alexeagle alexeagle requested review from mattem and thesayyn January 25, 2025 18:20
Copy link

github-actions bot commented Jan 25, 2025

LCOV of commit 9677f3f during CI #1625

Summary coverage rate:
  lines......: 100.0% (2 of 2 lines)
  functions..: 100.0% (1 of 1 function)
  branches...: no data found

Files changed coverage rate: n/a

Copy link

aspect-workflows bot commented Jan 25, 2025

Test

All tests were cache hits

29 tests (100.0%) were fully cached saving 55s.

@alexeagle alexeagle force-pushed the bzlmod1 branch 2 times, most recently from f92da8b to 863d03f Compare January 25, 2025 18:28
@alexeagle alexeagle marked this pull request as ready for review January 25, 2025 18:33
@alexeagle alexeagle merged commit 7d6423c into main Jan 27, 2025
16 checks passed
@alexeagle alexeagle deleted the bzlmod1 branch January 27, 2025 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants