Switch CI's minver check to use -Zminimal-versions #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using -Zdirect-minimal-versions now fails due to an indirect dependency (futures-util) now depending on a direct dependency (futures-channel). -Zdirect-minimal-versions brings in the latest version of every indirect dependency, which conflicts with bringing in the oldest version of futures-channel. A complicating factor is that every version of futures-util from 0.3.0 to 0.3.30, inclusive, has been yanked. Unwisely, IMHO.
Just because futures-util yanked all of its versions that are compatible with older compilers.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #61 +/- ##
=======================================
Coverage 92.85% 92.85%
=======================================
Files 3 3
Lines 434 434
=======================================
Hits 403 403
Misses 31 31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using -Zdirect-minimal-versions now fails due to an indirect dependency (futures-util) now depending on a direct dependency (futures-channel). -Zdirect-minimal-versions brings in the latest version of every indirect dependency, which conflicts with bringing in the oldest version of futures-channel.
A complicating factor is that every version of futures-util from 0.3.0 to 0.3.30, inclusive, has been yanked. Unwisely, IMHO.