Add option to control generation of timestamps. #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -296,7 +296,7 @@ def build_pdf_info doc | |||
| info[:Creator] = str2pdfval %(Asciidoctor PDF #{::Asciidoctor::Pdf::VERSION}, based on Prawn #{::Prawn::VERSION}) | |||
| info[:Producer] ||= (info[:Author] || info[:Creator]) | |||
| # FIXME use docdate attribute | |||
| info[:ModDate] = info[:CreationDate] = ::Time.now | |||
| info[:ModDate] = info[:CreationDate] = ::Time.now if doc.attr 'timestamps' | |||
There was a problem hiding this comment.
Could you write this as:
if doc.attr? 'timestamps'Notice the question mark.
There was a problem hiding this comment.
I wasn't clear if doing "timestamps!" would result in the value being absent altogether. If so, that's a fine solution and I'm happy to make the change. Otherwise, if it's still present but false, I think that will break functionality.
|
We'll wait on the merge in core before merging this one. |
|
Now that the corresponding issue is merged in core, can you update this PR to align with the approach we took there (i.e., |
|
Sure. I'll pick that up tomorrow, now that I'm back in Houston. |
|
👍 Thanks! |
|
Updated. |
|
Thanks! |
mojavelinux
added a commit
that referenced
this pull request
Jan 3, 2016
Add option to control generation of timestamps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the corresponding change related to asciidoctor/asciidoctor#1453.