Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labeled lists missing styles (bold in term names) #776

Closed
abelsromero opened this issue Mar 19, 2017 · 4 comments
Closed

Labeled lists missing styles (bold in term names) #776

abelsromero opened this issue Mar 19, 2017 · 4 comments
Assignees

Comments

@abelsromero
Copy link
Member

abelsromero commented Mar 19, 2017

Comparing HTML and PDF renderings I noticed that labeled lists don't show term names in bold.

. PDF on the right, HTML on the left
image

Also, I did not see any way to customise it with a style (/~https://github.com/asciidoctor/asciidoctor-pdf/blob/master/docs/theming-guide.adoc).
For me, not highlighting the term in bold breaks the readability and makes labeled list lest useful in PDF.

Is there a way to get it?

@mojavelinux
Copy link
Member

What you are looking for is the description list configuration, specifically term_font_style.

description_list:
  term:
    font_style: bold

However, I agree that this should be the default. The italic style is a carryover from the custom theme we had original done for Asciidoctor PDF and was not intended to align with the standard look. All the CSS frameworks, and HTML itself, use bold by default, and so should we.

@mojavelinux mojavelinux added this to the v1.5.0.alpha.15 milestone Mar 23, 2017
@mojavelinux mojavelinux self-assigned this Mar 23, 2017
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Mar 23, 2017
@mojavelinux
Copy link
Member

Btw, "labeled list" is an outdated term. The proper term is "description list" (according the wise people of the HTML specification).

@abelsromero
Copy link
Member Author

abelsromero commented Mar 24, 2017

Btw, "labeled list" is an outdated term. The proper term is "description list" (according the wise people of the HTML specification).

Thanks for the appreciation, I really do. But should the manual include that also here?
Something like Labeled lists (also known as description list in HTML jargon).

edit: fixed doc link, I meant the Labeled list file.

@mojavelinux
Copy link
Member

Yes, this chapter in the user manual named Labeled list needs to be renamed and the terminology updated. I'll file an issue in asciidoctor.org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants