Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If an error occurs when embedding an image, display the alt text instead #693

Closed
mojavelinux opened this issue Dec 11, 2016 · 1 comment
Closed

If an error occurs when embedding an image, display the alt text instead #693

mojavelinux opened this issue Dec 11, 2016 · 1 comment
Assignees
@mojavelinux
Labels
improvement
Milestone
v1.5.0.alpha.14

Comments

@mojavelinux
Copy link
Member

If an error occurs while attempting to embed an image into the PDF, display the alt text instead (as well as the caption, if one is present). Currently, only the caption is shown. This makes the behavior inconsistent with that of preemptive failures (such as when the image file is missing).

Verify this behavior for both block and inline images.
@mojavelinux mojavelinux added this to the v1.5.0.alpha.14 milestone Dec 11, 2016
@mojavelinux mojavelinux self-assigned this Dec 11, 2016
@mojavelinux
Copy link
Member Author

It might make sense to introduce a layout_alt_text helper method. The alternative is to move the begin/rescue block to the method and use an exception to control the flow.

mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Dec 25, 2016
@mojavelinux
resolves asciidoctor#693 show alt text when image fails to embed
3b29086
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Dec 26, 2016
@mojavelinux
resolves asciidoctor#693 show alt text when image fails to embed
365ae31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mojavelinux mojavelinux

Labels
improvement
Projects
None yet
Milestone
v1.5.0.alpha.14
Development

No branches or pull requests
1 participant
@mojavelinux