Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG images in header or footer don't respect pdfwidth attributes #625

Closed
tkfu opened this issue Oct 13, 2016 · 1 comment
Closed

SVG images in header or footer don't respect pdfwidth attributes #625

tkfu opened this issue Oct 13, 2016 · 1 comment
Assignees
Labels

Comments

@tkfu
Copy link

tkfu commented Oct 13, 2016

I'm trying to put a logo in the header, which I have as a nice clean SVG. It works just fine with the pdfwidth attribute on the title page; logo_image: image:a-plus-logo.svg[pdfwidth=25%] gives me the expected output.

However, any sizing directives I try to give it for the one in the header or footer just get ignored. The screenshot attached here is with content: image:a-plus-logo.svg[pdfwidth=10%], but I've also tried the scaledwidth and width attributes, and with different units specified (px and in). No matter what I do, the image stays the same size. I do have a workaround at the moment: I just use separate SVG files for different sizes. But that's not ideal, especially since it's a trial-and-error process to get the sizes right.

The pdfwidth attribute works as expected in the header/footer when the image is a PNG, but I'd much rather use a vector format in this case.

screen shot 2016-10-13 at 4 27 04 pm

@mojavelinux
Copy link
Member

mojavelinux commented Oct 13, 2016 via email

@mojavelinux mojavelinux added this to the v1.5.0.alpha.14 milestone Oct 13, 2016
@mojavelinux mojavelinux self-assigned this Oct 13, 2016
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Oct 15, 2016
…g content

- honor pdfwidth attribute for image in running content
- position SVG correctly
- only fit image to bounds if fit=contain or fit=scale-down attribute is used
- calculate image width from percentage value based on column width, not content width
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Oct 15, 2016
…g content

- honor pdfwidth attribute for image in running content
- position SVG correctly
- only fit image to bounds if fit=contain or fit=scale-down attribute is used
- calculate image width from percentage value based on column width, not content width
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Oct 16, 2016
…g content

- honor pdfwidth attribute for image in running content
- position SVG correctly
- only fit image to bounds if fit=contain or fit=scale-down attribute is used
- calculate image width from percentage value based on column width, not content width
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Oct 16, 2016
…g content

- honor pdfwidth attribute for image in running content
- position SVG correctly
- only fit image to bounds if fit=contain or fit=scale-down attribute is used
- calculate image width from percentage value based on column width, not content width
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Oct 16, 2016
…g content

- honor pdfwidth attribute for image in running content
- position SVG correctly
- only fit image to bounds if fit=contain or fit=scale-down attribute is used
- calculate image width from percentage value based on column width, not content width
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Oct 16, 2016
…g content

- honor pdfwidth attribute for image in running content
- position SVG correctly, including vertical alignment
- only fit image to bounds if fit=contain or fit=scale-down attribute is used
- calculate image width from percentage value based on column width, not content width
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Oct 16, 2016
…g content

- honor pdfwidth attribute for image in running content
- position SVG correctly, including vertical alignment
- only fit image to bounds if fit=contain or fit=scale-down attribute is used
- calculate image width from percentage value based on column width, not content width
mojavelinux added a commit that referenced this issue Oct 29, 2016
resolves #625 honor pdfwidth attribute for image in running content
fapdash pushed a commit to vogellacompany/asciidoctor-pdf that referenced this issue Dec 13, 2016
…g content

- honor pdfwidth attribute for image in running content
- position SVG correctly, including vertical alignment
- only fit image to bounds if fit=contain or fit=scale-down attribute is used
- calculate image width from percentage value based on column width, not content width
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants