-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the theme to specify a default pdfwidth value #455
Comments
We have one condition to work out. If a default image width is specified in the theme, should that value take precedence over the width value in the image macro? (generally, the value of the width attribute is intended as metadata only, not for sizing). We also need to decide on a name for the key. image_default_width? (It does have to start with image_). |
The most detailed value should be the used one. If no value is specified in image: the default value should be used, otherwise the the specified value. In DocBook I used the default one to define the size for all "normal" images, expect the very few that needed a special setting.
Sounds good. If it is specific for the PDF output I would add also add pdf, e.g., image_default_pdfwidth |
It's in the PDF theme, so PDF is already implied here. |
So to clarify, the default (specified in the theme) would not be used in this case:
but it would be used in this case:
correct? |
Sounds perfect for me. |
👍 |
I think the default width specified in the theme ( I'm proposing the following precedence:
|
- allow default value for pdfwidth attribute to be specified in theme - only allow vw units when resolving width for block image - use ViewportWidth module to mark width with vw units - consolidate variable names
+1 for the proposal |
- allow default value for pdfwidth attribute to be specified in theme - only allow vw units when resolving width for block image - use ViewportWidth module to mark width with vw units - consolidate variable names
- allow default value for pdfwidth attribute to be specified in theme - only allow vw units when resolving width for block image - use ViewportWidth module to mark width with vw units - consolidate variable names
- allow default value for pdfwidth attribute to be specified in theme - only allow vw units when resolving width for block image - use ViewportWidth module to mark width with vw units - consolidate variable names
- allow default value for pdfwidth attribute to be specified in theme - only allow vw units when resolving width for block image - use ViewportWidth module to mark width with vw units - consolidate variable names
… (PR asciidoctor#513) - allow default value for pdfwidth attribute to be specified in theme - only allow vw units when resolving width for block image - use ViewportWidth module to mark width with vw units - consolidate variable names
The theme should allow to specify a default pdfwidth value for images to be used if the pdfwidth attribute is not specified.
See #453
The text was updated successfully, but these errors were encountered: