Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for SVG to image reference in SVG encoded as a data URI (SVG data loader) #2512

Closed
scuba1012002 opened this issue Mar 22, 2024 · 1 comment
Closed

Add support for SVG to image reference in SVG encoded as a data URI (SVG data loader) #2512

scuba1012002 opened this issue Mar 22, 2024 · 1 comment
Assignees
@mojavelinux
Labels
improvement v2.3.16
Milestone
v2.3.x

Comments

@scuba1012002
Copy link

In the file from the asciidoctor-pdf repo
lib/asciidoctor/pdf/ext/prawn-svg/loaders/data.rb it was advised to remove the
regex
REGEXP = %r(\Adata:image/(?:png|jpe?g);base64(?:;[a-z0-9]+)*,)i
restriction now that prawn-svg supports SVG image references in SVG

Regex from prawn:
REGEXP = %r{\Adata:image/(png|jpeg|svg\+xml);base64(;[a-z0-9]+)*,}i
@scuba1012002 scuba1012002 changed the title Remove asciidoctor SVG image reference Remove asciidoctor SVG image restriction Mar 22, 2024
@mojavelinux mojavelinux changed the title Remove asciidoctor SVG image restriction Add support for SVG to image referece in SVG encoded as a data URI (SVG data loader) Mar 22, 2024
@mojavelinux mojavelinux self-assigned this Mar 22, 2024
@mojavelinux mojavelinux added this to the v2.3.x milestone Mar 22, 2024
@mojavelinux
Copy link
Member

This is related to prawn-svg upgrade in 2.3.14.

@mojavelinux mojavelinux changed the title Add support for SVG to image referece in SVG encoded as a data URI (SVG data loader) Add support for SVG to image reference in SVG encoded as a data URI (SVG data loader) May 31, 2024
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue May 31, 2024
@mojavelinux
resolves asciidoctor#2512 support base64-encoded SVG image reference …
757b386 
…in SVG
mojavelinux added a commit that referenced this issue May 31, 2024
@mojavelinux
resolves #2512 support base64-encoded SVG image reference in SVG (PR #…
f1d3561 
…2524)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mojavelinux mojavelinux

Labels
improvement v2.3.16
Projects
None yet
Milestone
v2.3.x
Development

No branches or pull requests
2 participants
@mojavelinux @scuba1012002