Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

included file inside table cell doesn't render footnotes #2410

Closed
philip-stuckey opened this issue Mar 24, 2023 · 3 comments
Closed

included file inside table cell doesn't render footnotes #2410

philip-stuckey opened this issue Mar 24, 2023 · 3 comments
Assignees
Milestone

Comments

@philip-stuckey
Copy link

hello, I have a fairly complicated document, and I tried putting two subsections in a two column format by putting them in a table, but I found the footnotes in the subsections disappeared. I have narrowed it down to this minimum-working example.
Everything in the block comment is supposed to be a separate file that the first one is including

[cols="1a"]
|===
|include::separate-document.adoc[]
|this seems to work fine{empty}footnote:[this footnote shows up]
|===

in separate-document.adoc

when this file is included, the footnote is nowhere to be seen
footnote:[this footnote should appear in the including document, so here it should show up twice]

here are the results
image

see how the first footnote at the bottom is "[2]"?
when I ran this in normal asciidoctor the footnotes appear in the bottom of their respective cells as opposed to the bottom of the page.
note that this is in asciidoctor-pdf version 2.3.4 using asciidoctor 2.0.18

@philip-stuckey
Copy link
Author

seems related to #1777 except the footnote isn't rendered only if it's included from another document

@philip-stuckey philip-stuckey changed the title included inside doen't render footnotes included file inside table cell doesn't render footnotes Mar 24, 2023
@mojavelinux
Copy link
Member

The include directive is a red herring here. This happens with or without the include. For some reason, the first footnote is being dropped. I'm investigating.

mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Mar 25, 2023
@mojavelinux mojavelinux self-assigned this Mar 25, 2023
@mojavelinux mojavelinux added this to the v2.3.x milestone Mar 25, 2023
@mojavelinux
Copy link
Member

mojavelinux commented Mar 25, 2023

(Note to self) Apply this fix to main, then backport to the 2.3.x branch.

mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Mar 27, 2023
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants