Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this a bug: code-caption-margin-outside moves caption text but not background #2271

Closed
mygithubdevaccount opened this issue Jul 1, 2022 · 3 comments
Assignees
Milestone

Comments

@mygithubdevaccount
Copy link

mygithubdevaccount commented Jul 1, 2022

When I specify:

code-caption-margin-outside: 6pt
code-caption-background-color: #EFEFEF

then the caption text moves down, and the background color moves up, like this:

screenshot

Maybe it's intended. I don't know.

My expectation would be:

expectation

p.s. thanks for your awesome work

@mojavelinux mojavelinux self-assigned this Jul 2, 2022
@mojavelinux mojavelinux added the bug label Jul 2, 2022
@mojavelinux mojavelinux added this to the v2.1.x milestone Jul 2, 2022
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Jul 2, 2022
@mojavelinux
Copy link
Member

Yep, you're right. The margin is being added instead of subtracted, which puts it on the wrong side of the boundary.

@mojavelinux mojavelinux modified the milestones: v2.1.x, v2.0.x Jul 3, 2022
mojavelinux added a commit that referenced this issue Jul 3, 2022
@mygithubdevaccount
Copy link
Author

Thank you, Tested it locally, and it works now as expected! Thank you for that quick fix!

@mojavelinux
Copy link
Member

Thank you for testing and verifying the fix!

I'm going to wait a few days to see if any other issues arise. If not, I'll push out a patch release that includes the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants