Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Value of page-count attribute is incorrect when start-at for running content and page numbering differ #1334

Closed
lorrden opened this issue Oct 17, 2019 · 2 comments
Assignees
Labels
Milestone

Comments

@lorrden
Copy link

lorrden commented Oct 17, 2019

This is related to Issue #869. The {page-count} attribute is the number of pages with running content, so “{page-number} of {page-count}”, will only generate reasonable numbering if page_numbering_start_at is the same as running_content_start_at.

My usecase is to have running content starting at the TOC (and a custom title page with title-specific footers and headers generated by an extension) but page numbering starting at the title page. It seems saner to set page-count based on page_numbering_start instead of running_content_start_at.

@mojavelinux
Copy link
Member

It seems saner to set page-count based on page_numbering_start instead of running_content_start_at.

I agree. It seems we are missing a test. I'll look into it.

@mojavelinux mojavelinux self-assigned this Oct 17, 2019
@mojavelinux mojavelinux added this to the v1.5.0 milestone Oct 17, 2019
@mojavelinux
Copy link
Member

This looks like it will be pretty easy to fix. The converter is just using the wrong variable name when computing the page count. All the information we need to get it right is available.

mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Oct 18, 2019
- handle case when page numbering and running content don't start on same page
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Oct 19, 2019
- handle case when page numbering and running content don't start on same page
@mojavelinux mojavelinux changed the title page-count attribute excludes Value of page-count attribute is incorrect when start-at for running content and page numbering differ Oct 20, 2019
@mojavelinux mojavelinux modified the milestones: v1.5.0, 1.5.0.beta.7 Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants