Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow theme to specify complete border and background color for quote and verse blocks #1309

Closed
mojavelinux opened this issue Oct 8, 2019 · 0 comments
Closed

Allow theme to specify complete border and background color for quote and verse blocks #1309

mojavelinux opened this issue Oct 8, 2019 · 0 comments
Assignees
@mojavelinux
Labels
enhancement
Milestone
v1.5.0.rc.1

Comments

@mojavelinux
Copy link
Member

Currently, the border for a quote or verse block is only drawn on the left side, and the background color cannot be set. It should be possible to specify a complete border and a background color.

This will require changing the behavior of the border_width key. Since it's customary to only want to draw a line on the left side, that feature should still be supported via the border_left_width key. If the border_width is specified, it takes precedence over this key.
@mojavelinux mojavelinux added this to the v1.5.0 milestone Oct 8, 2019
@mojavelinux mojavelinux self-assigned this Oct 8, 2019
@mojavelinux mojavelinux modified the milestones: v1.5.0, v2.0.0 Nov 22, 2019
@mojavelinux mojavelinux modified the milestones: v2.0.0, v1.5.0 Dec 30, 2019
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Dec 31, 2019
@mojavelinux
resolves asciidoctor#1309 allow theme to specify background color and…
af28601 
… full border for quote and verse blocks
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Dec 31, 2019
@mojavelinux
resolves asciidoctor#1309 allow theme to specify background color and…
66c303f 
… full border for quote and verse blocks
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Dec 31, 2019
@mojavelinux
resolves asciidoctor#1309 allow theme to specify background color and…
33fd3b6 
… full border for quote and verse blocks
@mojavelinux mojavelinux modified the milestones: v1.5.0, v1.5.0.rc.1 Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mojavelinux mojavelinux

Labels
enhancement
Projects
None yet
Milestone
v1.5.0.rc.1
Development

No branches or pull requests
1 participant
@mojavelinux