-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FontAwesome version is too new, big difference with html version #1157
Comments
Icon integration and selection is handled by prawn-icon. If you want to see
support for FontAwesome 4 restored, you'll need to take your case up there.
If that project decides to support it, then we can talk about how to enable
it as the default icon set in your document (something like icon-set=fa4).
|
Seems reasonable yes. What about the option to use older version of prawn-icon (prawn-icon 1.4.0)? I see the version hardcoded here: /~https://github.com/asciidoctor/asciidoctor-pdf/blob/master/asciidoctor-pdf.gemspec Also, for anyone reading this looking for a quick fix, here's an example to work around this restriction with the hdd icon:
|
Yep. This was a safe place to begin experimenting with FontAwesome 5 so that we could better understand what's coming. It was also necessary since prawn-icon made the switch and we depend on that library. |
It's a hard dependency on the API, so Asciidoctor PDF cannot easily float between different versions. We have to pick a version to depend on. |
There's a slightly simpler solution. You can set the icon set to fa4 (either on the document or on the icon) and prawn-icon will remap the old names to the new ones (if the icon is still available). However, in saying that it seems like there is a bug that is preventing this from working for fa4. I will add a portability test and fix the issue so that it will work. Here's what we expect to work:
or
I thought that worked, but clearly it's not working right now :/ |
yeah that's what I had initially tried too. |
Thanks for bringing this to my attention because I had no idea this was broken. As it turns out, we are completely missing tests for this remapping, which certainly explains it. 😱 |
…s when icon set is not specified
With the change proposed in #1160, you should not have to change your document. It will work just as if you are using Font Awesome 4...only the style of icons will obviously be different. |
(TBH, I really don't understand why the style of the Font Awesome icons was changed...but that's just the way it is). |
Asciidoctor currently only supports FontAwesome 4 icons ( asciidoctor/asciidoctor#3222 )
Asciidoctor-pdf currently uses prawn-icon 2.2.0 which is based arround Fontawesome 5
As a result there's icons that wont show in asciidoctor html, and will in the pdf. Or vice versa.
Example, the icon hdd-o (https://fontawesome.com/v4.7.0/icon/hdd-o) or hdd (https://fontawesome.com/icons/hdd)
Is it an option to downgrade to prawn-icon 1.4.0? Thats the version with 4.7 FontAwesome.
The text was updated successfully, but these errors were encountered: