-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table cell padding setting not affect table header cells #1098
Comments
You're absolutely right. Somehow, that got dropped. I'll fix it, add support for table_head_cell_padding as well, then add a test. |
Of course, if you'd like to have a go at it, feel free! Here's the logic needed in the head section:
|
Unfortunately, I don't possess any Ruby skills so it would be hard to provide any solution from my side (not even saying about proper one with tests and support for table_head_cell_padding) |
No worries. I just wanted to make sure I didn't step in front of you if it's something you could do. |
* apply cell padding to table cells in the head row * allow the theme to control the padding of table cells in the head row using the table_head_cell_padding key
This got missed because the reference PDF for the chronicles example was created after the regression occurred. Had it been the other way around, the visual test would have caught it. But the test suite will catch any future regression. |
When working with version:
Following setting in custom theme:
Was affecting also cells in table header row. That is not the case for later versions - table header cells padding can't be customized anymore.
The text was updated successfully, but these errors were encountered: