Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.0.0 beta.6] Licenses & Visibility annotations #99

Merged
merged 10 commits into from
Oct 20, 2023
Merged

[2.0.0 beta.6] Licenses & Visibility annotations #99

merged 10 commits into from
Oct 20, 2023

Conversation

St4NNi
Copy link
Member

@St4NNi St4NNi commented Oct 19, 2023 •
edited
Loading

This is a major breaking update that adds licenses to all resources.

Changelog

  • Added License API to create and manage licenses
  • Added metadata license and (default)data license tags to all resources
  • Added functionality to add Non BelongsTo internal relations on creation
  • Update visibility annotations
  • Fix typos (plurals)
  • Add OpenAPI annotations for Notifications
  • Upgrade Rust dependencies

Fixes #98

@St4NNi St4NNi requested review from das-Abroxas and lfbrehm October 19, 2023 15:12
das-Abroxas
das-Abroxas reviewed Oct 19, 2023
View reviewed changes
Copy link
Contributor

@das-Abroxas das-Abroxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some suggestions to correct comments and naming. They can be addressed, but it wouldn't affect functionality if they were simply rejected.

Overall, it looks good to me and I will approve after the suggestions are applied or rejected 👍

aruna/api/notification/services/v2/notification_service.proto Outdated Show resolved Hide resolved
aruna/api/storage/models/v2/models.proto Outdated Show resolved Hide resolved
aruna/api/storage/services/v2/dataset_service.proto Outdated Show resolved Hide resolved
aruna/api/storage/services/v2/object_service.proto Outdated Show resolved Hide resolved
aruna/api/storage/services/v2/collection_service.proto Outdated Show resolved Hide resolved
aruna/api/storage/services/v2/license_service.proto Outdated Show resolved Hide resolved
aruna/api/storage/services/v2/license_service.proto Outdated Show resolved Hide resolved
aruna/api/storage/services/v2/license_service.proto Outdated Show resolved Hide resolved
aruna/api/storage/services/v2/project_service.proto Outdated Show resolved Hide resolved
St4NNi and others added 2 commits October 20, 2023 09:36
@St4NNi @das-Abroxas
chore: Rename notifications openapi path
da8d87e 
Co-authored-by: Jannis Hochmuth <jannis.hochmuth@gmail.com>
@St4NNi @das-Abroxas
chore: Apply naming suggestions
9ff2fb1 
Co-authored-by: Jannis Hochmuth <jannis.hochmuth@gmail.com>
@St4NNi St4NNi merged commit 60c5ad8 into main Oct 20, 2023
@St4NNi St4NNi deleted the 2.0.0-beta.6 branch October 20, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@das-Abroxas das-Abroxas das-Abroxas left review comments

@lfbrehm lfbrehm lfbrehm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@St4NNi @das-Abroxas @lfbrehm