-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Features: workspaces, list object v2, hooks #77
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only mandatory change I request is the PinCollectionVersion
endpoint URL.
Everything else is optional, but it would be nice if you addressed it somehow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @das-Abroxas regarding the name changes. Everything else looks good to me so far.
Co-authored-by: Jannis Hochmuth <jannis.hochmuth@gmail.com>
Co-authored-by: Jannis Hochmuth <jannis.hochmuth@gmail.com>
Co-authored-by: Jannis Hochmuth <jannis.hochmuth@gmail.com>
Co-authored-by: Jannis Hochmuth <jannis.hochmuth@gmail.com>
Co-authored-by: Jannis Hochmuth <jannis.hochmuth@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with that. Nice work 👍
Features
This is a major PR that adds several extensions to the API.
Workspaces
Added a
workspaces
API related to the collection API.workspaces
are anonymous collections in special projects that obey special rules. Everybody can create aworkspace
via a publiccreate_workspace
request that only needs a publicly available workspace project_name.Possible actions:
ListObjectV2
A new ListObjectV2 like request was added to query multiple objects and common prefixes via delimiters. This is a public endpoint and will be used by the data proxy to enable ListObjectV2 S3 behavior. See official AWS S3 documentation for behavior details.
HookService
Added a
HookService
that enables users to registerhooks
, which are custom actions that should be performed on objects.Trigger
that will trigger a run and a hook action that defines what should happen when the hook got triggered. In the first iteration this only has two options, call a specific URL with templated Json parameters or perform some Aruna internal actions with the object. The URL call needs to be validated by Credentials (first iteration only supports Bearer / Token authentication). Hooks are project specific for now and can only be created by project_admins.