Skip to content
This repository has been archived by the owner on Mar 12, 2020. It is now read-only.

[MX-96] Remove redundant screen view tracking for Artist page #2058

Merged
merged 1 commit into from
Jan 24, 2020

Conversation

ds300
Copy link
Contributor

@ds300 ds300 commented Jan 24, 2020

https://artsyproduct.atlassian.net/browse/MX-96

companion for artsy/eigen#2995 — removes one final redundant screen view event.

Copy link
Contributor

@ashfurrow ashfurrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, gotcha. That makes sense – revisiting the other PR, the double-tracking makes more sense now 👍

(That analytics DSL is, well it's not my proudest OSS contribution 😅) #mergeongreen

@artsy-peril artsy-peril bot merged commit 38fd081 into master Jan 24, 2020
@ashfurrow ashfurrow deleted the analytics-fixes branch January 24, 2020 15:28
@artsyit
Copy link
Collaborator

artsyit commented Jan 24, 2020

🚀 PR was released in v1.21.20 🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants