This repository has been archived by the owner on Mar 12, 2020. It is now read-only.
[MX-70] - Guard against S3 upload crash #2018
Merged
+43
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brainbicycle This looks good to me! Good job! |
brainbicycle
changed the title
|
🚀 PR was released in v1.20.4 🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show an error alert and allow retry rather than crash on unhandled JS Exception.
Copy in screenshot is out of date - updated copy is:
"Sorry, we couldn't upload your images." - (Removed optional s)
"Please try again or contact consign@artsy.net for help."
The error alert looks like this:
