This repository has been archived by the owner on Mar 12, 2020. It is now read-only.
Adds EmptyState, Horizontal Pagination and Artwork Counts to Partner also adds isCloseToEdge util #1956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kierangillen
force-pushed
the
partner-updates
branch
from
fe86e7a to
27b82ba
Compare
kierangillen
force-pushed
the
partner-updates
branch
from
20103ba to
d9e02a8
Compare
kierangillen
changed the title
ashfurrow
approved these changes
Nov 5, 2019
|
|
||
| type CallBack = () => void | ||
|
|
||
| export function isCloseToEdge(onScrollEnd: CallBack, pageEndThreshold: number = PAGE_END_THRESHOLD) { |
There was a problem hiding this comment.
Are we planning to add tests for this class? I'm comfortable merging as-is as long as we ticket the follow-up tests.
There was a problem hiding this comment.
We can, looks like there are no tests yet for isCloseToBottom so they could be grouped together.
There was a problem hiding this comment.
Added a ticket: https://artsyproduct.atlassian.net/browse/ME-99
|
The tests have passed but GitHub hasn't updated the build status. Merging. |
|
🚀 PR was released in v1.18.22 🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EmptyStateto each scrollviewisCloseToEdgemethod for horizontal paginationHorizontal pagination
Empty state
#skip_new_tests