Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

target_temperature unit not working. #151

Closed
skavan opened this issue Mar 30, 2024 · 6 comments · Fixed by #152
Closed

target_temperature unit not working. #151

skavan opened this issue Mar 30, 2024 · 6 comments · Fixed by #152

Comments

@skavan
Copy link

skavan commented Mar 30, 2024

Hi,
First of all - great card. I'm a bit of pixel-perfect guy so spent 280 lines of yaml to fine tune it!
Here's what it looks like:
image
The one thing I can't figure out how to get 67°C to read 67°F.
I thought it was:

- type: custom:mini-climate
  entity: climate.porch_ac_windfree_3_0e
  icon: blank
  scale: 1
  hide_current_temperature: true
  target_temperature:
    icons:
      up: mdi:chevron-up
      down: mdi:chevron-down
    unit: '°F'

But it doesn't work. Am I missing a trick, or is it a bug?

p.s. Here's the off display (a few posts have asked about hiding stuff, and greying out stuff -- card_mod is your friend!).
If anyone cares I can post all 280 lines of yaml!
image

@regevbr
Copy link
Collaborator

regevbr commented Mar 31, 2024

You need to set the unit also on temperature and not just target_temperature

@skavan
Copy link
Author

skavan commented Mar 31, 2024

Success. Thank you. You might want to note that in the readme unless I missed it. It's not entirely logical! Very cool card.
When I have time, I'll comment and send over my huge card_mod block; perhaps you would consider putting some of the functionality in the core.

@regevbr
Copy link
Collaborator

regevbr commented Apr 1, 2024

image
If you feel it requires a change a PR is more than welcome

@regevbr regevbr closed this as completed Apr 1, 2024
@regevbr
Copy link
Collaborator

regevbr commented Apr 1, 2024

Actually it is confusing, I see what is the issue in the code I will fix

@regevbr
Copy link
Collaborator

regevbr commented Apr 1, 2024

released in 2.7.2 @skavan can you please verify it is fixed by removing the unit in the temperature entry?

@skavan
Copy link
Author

skavan commented Apr 1, 2024

Looks like it's fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants