Add logic check for if page is published if not 404 [WEB-2988] #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikhiltri
requested changes
Dec 19, 2024
web-dev-trev
force-pushed
the
fix/press-releases-published-statuts
branch
from
7eb6952 to
4bef2f4
Compare
web-dev-trev
requested review from
nikhiltri
and removed request for
zachgarwood
|
web-dev-trev
commented
Dec 19, 2024
| @@ -149,7 +149,7 @@ protected function getNavElements($title) | |||
|
|
|||
| public function show($id) | |||
| { | |||
| $item = $this->repository->getById((int) $id); | |||
| $item = $this->repository->published()->findOrFail((int) $id); | |||
There was a problem hiding this comment.
@nikhiltri the getById method is a twill model method and not an eloquent one so I replaced it with the findOrFail which will 404 👍
web-dev-trev
added a commit
that referenced
this pull request
Dec 19, 2024
…ses-published-statuts Add logic check for if page is published if not 404 [WEB-2988]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.