Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken tests by installing unzip dependency. #18

Merged
merged 1 commit into from
Oct 12, 2016

Conversation

geerlingguy
Copy link
Contributor

No description provided.

@geerlingguy
Copy link
Contributor Author

geerlingguy commented Oct 12, 2016

Tests that are passing:

  • CentOS 7
  • CentOS 6
  • Ubuntu 16.04
  • Ubuntu 14.04
  • Ubuntu 12.04

@arknoll
Copy link
Owner

arknoll commented Oct 12, 2016

Thanks @geerlingguy!

@geerlingguy
Copy link
Contributor Author

For 14.04, it seems the init script is causing a problem with idempotence.

For 12.04, it looks like Chrome isn't installable on 12.04, so we can either drop 12.04 or dynamically change the default to Firefox instead, just for 12.04.

@arknoll arknoll merged commit 626310f into arknoll:master Oct 12, 2016
@geerlingguy
Copy link
Contributor Author

@arknoll - it looks like Google doesn't support either Ubuntu 12.04 or CentOS 6: http://superuser.com/a/878733/80658

We should either drop official support for those OSes or switch the default on the fly to Firefox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants