Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/controller: track reconciliation failure count #263

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Conversation

datdao
Copy link
Member

@datdao datdao commented Feb 11, 2025

This pull request introduces a new field (failed) to track the number of failed when the operator encounters an error. The recorded value will be used to calculate backoff time in the next PR

@datdao datdao requested review from giautm and rotemtam and removed request for giautm February 11, 2025 18:40
Copy link
Member

@giautm giautm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the default value is a negative number?

@datdao datdao changed the title internal/controller: track retry attempts on error internal/controller: track reconciliation failure count Feb 12, 2025
@datdao datdao requested a review from giautm February 12, 2025 04:06
@datdao datdao merged commit 59af26e into master Feb 12, 2025
5 of 6 checks passed
@datdao datdao deleted the d/backoff branch February 12, 2025 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants