update oras push syntax to fix issue with 0 length config #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! Did you confirm it worked with Trivy? |
|
Yes, I have tested this with an install of Trivy on our air-gapped network, and it works with out any issues. This is a relatively small change and will have no negative impact to users. |
|
This PR coincides with aquasecurity/trivy-db#305 |
|
Thanks for confirming. We also need to test it on our end. |
|
Here are the successful database builds: And here is a successful trivy scan using these builds: |
|
Hello @knqyf263 Trivy works correctly with these changes. |
DmitriyLewen
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the syntax used to push the OCI artifact. Using /dev/null as the source for the config results in a zero (0) length blob, this causes an error when using
oras copyto copy the artifact to another v2 API registry. Using the new--artifact-typeparameter creates a config of the given type, containing an empty json object{}, and allows for the artifact to be copied successfully.This change is necessary to allow the trivy java db OCI artifact to be copied to a registry hosted on an air-gapped network.