GetKeyValuesAndFlatMap should return error if not retriable #5967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS CodeBuild CI Report for macOS Catalina 10.15
|
nblintao
force-pushed
the
flatmap-exception
branch
from
dcb9a68 to
f1e9134
Compare
AWS CodeBuild CI Report for Linux CentOS 7
|
AWS CodeBuild CI Report for Linux CentOS 7
|
halfprice
reviewed
Nov 12, 2021
fdbserver/storageserver.actor.cpp
Outdated
| GetKeyValuesAndFlatMapReply _r = wait(flatMap(data, getKeyValuesReply, req.mapper)); | ||
| r = _r; | ||
| } catch (Error& e) { | ||
| TraceEvent(SevInfo, "FlatMapError").error(e); |
| @@ -109,17 +110,27 @@ struct IndexPrefetchDemoWorkload : TestWorkload { | |||
| mapper, | |||
| GetRangeLimits(CLIENT_KNOBS->TOO_MANY))); | |||
| showResult(result); | |||
| if (self->BAD_MAPPER) { | |||
| TraceEvent("IndexPrefetchDemoWorkloadShouldNotReachable").detail("ResultSize", result.size()); | |||
| // UNREACHABLE(); | |||
There was a problem hiding this comment.
Remove commented out code?
nblintao
force-pushed
the
flatmap-exception
branch
from
f1e9134 to
2d5f924
Compare
halfprice
approved these changes
Nov 12, 2021
AWS CodeBuild CI Report for Linux CentOS 7
|
nblintao
added a commit
to nblintao/foundationdb
that referenced
this pull request
Nov 13, 2021
…to FDB This includes apple#5945 apple#5955 apple#5965 apple#5967 apple#5978 from master
nblintao
added a commit
to nblintao/foundationdb
that referenced
this pull request
Nov 13, 2021
…to FDB This includes apple#5945 apple#5955 apple#5965 apple#5967 apple#5978 from master
5 tasks
nblintao
added a commit
to nblintao/foundationdb
that referenced
this pull request
Nov 13, 2021
…to FDB This includes apple#5945 apple#5955 apple#5965 apple#5967 apple#5978 from master
nblintao
added a commit
to nblintao/foundationdb
that referenced
this pull request
Nov 13, 2021
…to FDB This includes apple#5945 apple#5955 apple#5965 apple#5967 apple#5978 from master
nblintao
added a commit
to nblintao/foundationdb
that referenced
this pull request
Nov 13, 2021
…to FDB This includes apple#5945 apple#5955 apple#5965 apple#5967 apple#5978 from master
nblintao
added a commit
to nblintao/foundationdb
that referenced
this pull request
Nov 15, 2021
…to FDB This includes apple#5945 apple#5955 apple#5965 apple#5967 apple#5978 from master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently find out that the
GetKeyValuesAndFlatMapendpoint will retry forever for a non-retriable error (e.g. the "mapper" in user's request is invalid). We need this fix in 7.0 to make the new feature useful.Code-Reviewer Section
The general guidelines can be found here.
Please check each of the following things and check all boxes before accepting a PR.
For Release-Branches
If this PR is made against a release-branch, please also check the following:
release-branchormasterif this is the youngest branch)