Support parens #99
Merged
Support parens #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pvinis: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
pvinis
commented
May 17, 2023
|
|
||
| it("works with parens", () => { | ||
| const textDocument = mockTextDocument(` | ||
| gql(\` |
pvinis
commented
May 17, 2023
| } | ||
|
|
||
| \${ReviewList.fragments.reviews} | ||
| \`) |
|
gh doesnt allow me to add you as a reviewer, so ill just tag here. @jgzuke |
|
tested locally with |
|
bundled up here. if you wanna use this PR's version of the extension:
|
|
LGTM |
alessbell
reviewed
Oct 16, 2023
syntaxes/graphql.js.json
Outdated
| @@ -14,7 +14,7 @@ | |||
| "name": "punctuation.definition.string.template.begin.js" | |||
| } | |||
| }, | |||
| "end": "`", | |||
| "end": "`\\(?", | |||
There was a problem hiding this comment.
Did you mean a closing parenthesis here?
Edit: pushed up this change.
Suggested change
| "end": "`\\(?", | |
| "end": "`\\)?", |
alessbell
force-pushed
the
support-parens
branch
from
e764b5d to
146bc35
Compare
alessbell
approved these changes
Oct 16, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out not too hard to fix. i added the parens in the regex.
Fixes #98.