Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle extension instead of just building it #169

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Bundle extension instead of just building it #169

merged 3 commits into from
Aug 12, 2024

Conversation

phryneas
Copy link
Member

@phryneas phryneas commented Aug 12, 2024 •
edited
Loading

This brings the extension down from shipping a 50-MB-ish node_modules to a prebuilt 6MB (<2MB packed)

Before:

image

After:

image

@phryneas phryneas marked this pull request as ready for review August 12, 2024 14:26
alessbell
alessbell approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@alessbell alessbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@phryneas
Copy link
Member Author

PS: most config taken from https://code.visualstudio.com/api/working-with-extensions/bundling-extension

@phryneas phryneas merged commit ff4f0de into main Aug 12, 2024
7 checks passed
@phryneas phryneas deleted the pr/bundle branch August 12, 2024 14:38
@github-actions github-actions bot mentioned this pull request Aug 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessbell alessbell alessbell approved these changes

@jerelmiller jerelmiller Awaiting requested review from jerelmiller

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phryneas @alessbell