Fix configuration error display #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phryneas
commented
Aug 8, 2024
Comment on lines
+200
to
+203
| throw fromZodError(parsed.error, { | ||
| prefix: `Error parsing config file ${configURI?.fsPath}:`, | ||
| prefixSeparator: "\n", | ||
| issueSeparator: ";\n", | ||
| unionSeparator: "\n or\n", | ||
| }); |
There was a problem hiding this comment.
There was a full mechanism for handling thrown errors, but instead a lot of places logged errors instead. Defaulting to throwing in most places now.
phryneas
commented
Aug 8, 2024
Comment on lines
+27
to
+32
| const { sendNotification: originalSendNotification } = connection; | ||
| connection.sendNotification = async (...args: [any, ...any[]]) => { | ||
| await whenConnectionInitialized; | ||
| connection.sendNotification = originalSendNotification; | ||
| connection.sendNotification(...args); | ||
| }; |
There was a problem hiding this comment.
All sendNotification calls before the LSP client was fully started were swallowed previously - this included Debug.error etc.
This queues them instead.
phryneas
commented
Aug 8, 2024
Comment on lines
-64
to
-65
| await whenConnectionInitialized; | ||
|
|
There was a problem hiding this comment.
This was the one place that already had handling for that - we don't need that exception anymore.
phryneas
force-pushed
the
pr/fix-configuration-error-display
branch
from
8423e82 to
4318a11
Compare
|
No ideas why tests are failing on this, they pass locally. Gotta take a look tomorrow. |
phryneas
force-pushed
the
pr/fix-configuration-error-display
branch
from
258cc99 to
af8b2ae
Compare
|
So... |
phryneas
force-pushed
the
pr/fix-configuration-error-display
branch
2 times, most recently
from
87c95db to
10d6866
Compare
alessbell
approved these changes
Aug 9, 2024
An error occurred while trying to automatically change base from
pr/better-config-handling
to
main
August 9, 2024 15:28
phryneas
force-pushed
the
pr/fix-configuration-error-display
branch
from
10d6866 to
9f461ea
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.