-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support type: module
with .cjs
file extension #2342
#2381
Conversation
@alexanderniebuhr: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
@jgzuke just saw you answering PRs and doing heavy work on the transition branch. Let me know if you need any more information! |
@alexanderniebuhr Thanks for moving that over to the new VS Code repository. Since there are remaining bits in this repository (e.g., the |
Conflicts look like they need to be resolved locally and I believe that all the CI failures are from linting (e.g., a run of Line 27 in c05c9e4
|
@abernix yeah you could reopen this and land it. My main concern was the VS Code Extension, so I just moved it over to the new repo. |
type: module
with .cjs
file extension #2342type: module
with .cjs
file extension #2342
close #2342
TODO:
*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.