Use weak references to Apollo client in closures #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -206,7 +215,7 @@ private func wrapResultHandler<Data>(_ resultHandler: GraphQLResultHandler<Data> | |||
| } | |||
|
|
|||
| private final class FetchQueryOperation<Query: GraphQLQuery>: AsynchronousOperation, Cancellable { | |||
| let client: ApolloClient | |||
| weak var client: ApolloClient? | |||
There was a problem hiding this comment.
Why does this need to be weak here?
There was a problem hiding this comment.
I think you're adding the operation to the client's queue
apollo-ios/Sources/Apollo/ApolloClient.swift
Lines 137 to 138 in 509b222
so both the client and the operation will be retained here
There was a problem hiding this comment.
oh woof, good point.
designatednerd
approved these changes
Oct 22, 2019
|
Anyone else who ends up here wondering why they're not getting any data back anymore... you're probably not holding onto a strong reference of the |
|
Ha, good catch! I'll make a note of it on the release notes for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes a few closures that were keeping a strong reference to the Apollo client. This is to make sure that as soon as the user of Apollo client releases its reference, all Apollo operations will stop.