Updating Persisted Query Configuration #3175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Anthony Miller <anthonymdev@gmail.com>
Moved operation manifest config options from file output and options to their own top level `OperationManifestConfiguration` item
✅ Deploy Preview for apollo-ios-docs canceled.
|
BobaFetters
commented
Aug 4, 2023
Moved operation manifest config options from file output and options to their own top level `OperationManifestConfiguration` item
…phql/apollo-ios into feature/persisted-query-update
AnthonyMDev
previously requested changes
Aug 4, 2023
...egenLib/CodegenConfiguration/ApolloCodegenConfiguration+OperationManifestConfiguration.swift
Outdated
Show resolved
Hide resolved
...egenLib/CodegenConfiguration/ApolloCodegenConfiguration+OperationManifestConfiguration.swift
Outdated
Show resolved
Hide resolved
AnthonyMDev
reviewed
Aug 8, 2023
AnthonyMDev
reviewed
Aug 8, 2023
There was a problem hiding this comment.
Can you also do a quick pass over the inline docs here, finding any reference to APQ and making sure it still is accurate. We now know that APQ and legacy safelisting are not the same feature. And we should just replace any references to the legacy safelisting with the new "persisted queries" only.
Co-authored-by: Anthony Miller <anthonymdev@gmail.com>
…phql/apollo-ios into feature/persisted-query-update # Conflicts: # Sources/ApolloCodegenLib/ApolloCodegenConfiguration.swift
AnthonyMDev
reviewed
Aug 8, 2023
...egenLib/CodegenConfiguration/ApolloCodegenConfiguration+OperationManifestConfiguration.swift
Outdated
Show resolved
Hide resolved
...egenLib/CodegenConfiguration/ApolloCodegenConfiguration+OperationManifestConfiguration.swift
Outdated
Show resolved
Hide resolved
...egenLib/CodegenConfiguration/ApolloCodegenConfiguration+OperationManifestConfiguration.swift
Outdated
Show resolved
Hide resolved
AnthonyMDev
reviewed
Aug 8, 2023
...s/ApolloCodegenTests/CodeGeneration/FileGenerators/OperationManifestFileGeneratorTests.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Anthony Miller <anthonymdev@gmail.com>
AnthonyMDev
approved these changes
Aug 9, 2023
Co-authored-by: Anthony Miller <anthonymdev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Moved all codegen config options related to persisted queries to a new top level
OperationManifestConfigurationobject-Added an
autoGenerateoption to determine if the operation manifest should be generated when using thegeneratecli command-Cleaned up/combined some code