fix: Updating test mock set method definitions #3089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Updated the definitions of the test mock _set method definitions -Updated MockObjectTemplate to generate mocks with new definitions
✅ Deploy Preview for apollo-ios-docs canceled.
|
BobaFetters
commented
Jun 22, 2023
BobaFetters
commented
Jun 22, 2023
| } | ||
| } | ||
| """) : TemplateString(stringLiteral: "") | ||
| ) | ||
|
|
||
| """ | ||
| } | ||
|
|
||
| private func getMockSetType(_ graphQLType: GraphQLType) -> String { |
There was a problem hiding this comment.
Not sure I like the name of this function, open to other suggestions here.
There was a problem hiding this comment.
Maybe just remove the get - mockSetType or something completely different in mockFunctionDescriptor.
| } | ||
| } | ||
| """) : TemplateString(stringLiteral: "") | ||
| ) | ||
|
|
||
| """ | ||
| } | ||
|
|
||
| private func getMockSetType(_ graphQLType: GraphQLType) -> String { |
There was a problem hiding this comment.
Maybe just remove the get - mockSetType or something completely different in mockFunctionDescriptor.
calvincestari
approved these changes
Jun 23, 2023
Sources/AnimalKingdomAPI/AnimalKingdomAPI/TestMocks/Bird+Mock.graphql.swift
Show resolved
Hide resolved
AnthonyMDev
approved these changes
Jun 23, 2023
There was a problem hiding this comment.
Two minor suggestions, but this looks great! Thanks so much @BobaFetters
AnthonyMDev
approved these changes
Jun 23, 2023
| case .entity(_): | ||
| return "Entity" | ||
| case .inputObject(_): | ||
| preconditionFailure() |
There was a problem hiding this comment.
Nit: might want to also add a message to this failure to help us identify the issue if a user ever encounters this and files a bug report.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Updated the definitions of the test mock _set method definitions
-Updated MockObjectTemplate to generate mocks with new definitions
Closes #3023
Closes #3043