Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating casing of variable names and keys #2996

Merged
merged 2 commits into from
May 8, 2023

Conversation

BobaFetters
Copy link
Member

-Updated the handling of all uppercase variable names & dictionary keys to ensure keys always match what is provided in the schema, and variables are converted to lowercase.

Closes #2858

-Updated the handling of all uppercase variable names & dictionary keys to ensure keys always match what is provided in the schema, and variables are converted to lowercase.
@BobaFetters BobaFetters linked an issue May 4, 2023 that may be closed by this pull request
Copy link
Member

@calvincestari calvincestari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, with one comment on reducing room for error.

Combining the `asFieldAccessorPropertyName` and `asInputParameterName` into a single `asFieldPropertyName` function.
@BobaFetters BobaFetters requested a review from calvincestari May 8, 2023 13:43
Copy link
Member

@calvincestari calvincestari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks for the fix @BobaFetters!

@BobaFetters BobaFetters changed the base branch from release/1.2 to main May 8, 2023 17:17
@BobaFetters BobaFetters merged commit 202894c into main May 8, 2023
@BobaFetters BobaFetters deleted the fix/generated-getter-setter-case branch May 8, 2023 17:17
This was referenced May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InputObjects generated with incorrect getter/setter key
2 participants