Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow callbackQueue to be specified for GraphQLWatcher #1723

Merged
merged 2 commits into from
Mar 22, 2021
Merged

Allow callbackQueue to be specified for GraphQLWatcher #1723

merged 2 commits into from
Mar 22, 2021

Conversation

ketenshi
Copy link
Contributor

As mentioned in /~https://github.com/apollographql/apollo-ios/discussions/1718 there may be situations where it makes sense to call the result handler for the GraphQLWatcher in a background thread to lessen the load of the main thread.

designatednerd
designatednerd reviewed Mar 17, 2021
View reviewed changes
Copy link
Contributor

@designatednerd designatednerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable, one minor note on the docs in response to your question

Sources/Apollo/ApolloClientProtocol.swift Show resolved Hide resolved
@ketenshi
Copy link
Contributor Author

@designatednerd lmk if there's something else you need from me for this PR

designatednerd
designatednerd approved these changes Mar 22, 2021
View reviewed changes
Copy link
Contributor

@designatednerd designatednerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the poke. LGTM!

@designatednerd designatednerd added this to the Next Release milestone Mar 22, 2021
@designatednerd designatednerd merged commit 034b334 into apollographql:main Mar 22, 2021
@ketenshi ketenshi deleted the watcher-queue branch March 22, 2021 20:02
@ketenshi ketenshi mentioned this pull request Apr 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@designatednerd designatednerd designatednerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.43.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ketenshi @designatednerd