Swift Package Manager 5.3 compatibility #1584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hing isn't a swift file
(caused API.json for swift codegen to regen with updated file paths)
designatednerd
commented
Dec 22, 2020
| guard fileURL.apollo.isSwiftFileURL else { | ||
| throw CodegenError.singleFileButNotSwiftFileURL(fileURL) | ||
| } | ||
| } // else we're fine with JSON at this point for intermediate purposes. |
There was a problem hiding this comment.
Once default codegen becomes swift codegen, this will fail the tests that check that a folder URL can't be passed in here.
designatednerd
commented
Dec 22, 2020
| @@ -1,10 +0,0 @@ | |||
| { | |||
| "63e25c339275a65f43b847e692e42caed8c06e25fbfb3dc8db6d4897b180c9ef": { | |||
There was a problem hiding this comment.
This was deleted because we switched to "operationIDs.json"
|
May the ghost of Steve Jobs have mercy on us all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
Package@swift-5.2.swiftto preserve backwards compatibilityStarWarsAPI,GitHubAPI, andUploadAPIinto excludedgraphqlfolders