Manual cancellation of in-flight operations

[designatednerd]

This should address #1376 - when a session was being invalidated, its in-flight tasks weren't being cancelled before being removed from the list of active tasks on URLSessionClient. Why not, since we were calling invalidateAndCancel, which is supposed to cancel active tasks? Turns out there's one verrrry important piece of information that only lives on the web docs:

Now, we're going through and actually cancelling all the tasks that are from the URLSessionClient before clearing out the array of active tasks. That should prevent tasks from calling back at a point where the assertion failure being hit in #1376 gets hit.

[designatednerd]

@RolandasRazma You wanna give this a shot and see if it resolves your issues?

[RolandasRazma]

wasn't it simpler to remove assert? :)
sure will check, thanks for looking into it

[designatednerd]

I definitely considered sending that to a debugPrint rather than an assert, but the assert is there to tell me things ain't working the way they're supposed to (while allowing things to fail more gracefully in prod).

[designatednerd]

@RolandasRazma any improvement?

[RolandasRazma]

So far so good. Wasn’t happening before all the time as well, but haven’t seen any on this branch

…

On 9 Sep 2020, at 23:22, Ellen Shapiro ***@***.***> wrote:  @RolandasRazma any improvement? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[designatednerd]

Cool, I'm gonna merge this and do a patch release then