Address retain cycle with URLSessionClient #1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1362 (at least partially) and #1292 (I believe in full).
The
URLSessionClientobject holding on to theURLSessionand being its delegate creates a retain cycle. However, hanging on to theURLSessionweakly doesn't work either, because it's just immediately deallocated:The somewhat inelegant solution is that you have to manually invalidate the
URLSessionClientand stop holding on to theURLSession. Fortunately for most people, we can haveHTTPNetworkClientdo this without them having to think about it. This does mean if you're usingURLSessionoutsideHTTPNetworkClientyou need to remember to do this, but for now I think that should be an edge case.