Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements feature request: #4313 #4320

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

rosco54
Copy link
Contributor

@rosco54 rosco54 commented Mar 12, 2024

Provide a "step before" version of the current "step after" line chart.

API:
Retain the existing "stepline" curve type for backward compatibility and denote the new type as "linestep".

Perhaps read these as "step follows line" and "line follows step" respectively.

Example:

stroke: {
curve: 'linestep'
}

Add e2e sample: source/line/linestep.xml and derived (built) samples.

Fixes #4313

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

fc3noor2 (1)

fc3noor2

@rosco54 rosco54 force-pushed the Step_after_line_chart branch from d9923e5 to 517dc78 Compare March 12, 2024 08:34
@junedchhipa
Copy link
Contributor

Please add types for this option in types/apexcharts.d.ts

Provide a "step before" version of the current "step after" line chart.

API:
Retain the existing "stepline" curve type for backward compatibility
and denote the new type as "linestep".

Example:

stroke: {
	curve: 'linestep'
}

Add e2e sample: source/line/linestep.xml and derived (built) samples.
@rosco54 rosco54 force-pushed the Step_after_line_chart branch from 517dc78 to db3d468 Compare March 12, 2024 12:30
@junedchhipa junedchhipa merged commit e5bf029 into apexcharts:main Mar 12, 2024
@rosco54 rosco54 deleted the Step_after_line_chart branch March 15, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stepline chart - choose preferred line interpolation
2 participants