Context size fixed #248
Merged
Context size fixed #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jan 1, 2018
assets/js/translator.js
Outdated
| $(this).attr('id', 'wordGettingSuggested'); | ||
| var wrapLength = parseInt(config.SUGGESTIONS.context_size); | ||
| context = getContext(fromWord, wrapLength); | ||
| $('#translatedTextClone').html(context); |
assets/js/translator.js
Outdated
| var fromWord = $(this).html(); | ||
| $(this).attr('id', 'wordGettingSuggested'); | ||
| var wrapLength = parseInt(config.SUGGESTIONS.context_size); | ||
| context = getContext(fromWord, wrapLength); |
assets/js/translator.js
Outdated
| $('#translatedTextClone').html($('#translatedText').attr('pristineText')); | ||
| var fromWord = $(this).html(); | ||
| $(this).attr('id', 'wordGettingSuggested'); | ||
| var wrapLength = parseInt(config.SUGGESTIONS.context_size); |
assets/js/translator.js
Outdated
| var markedWord = mark + fromWord; | ||
| var rawText = $("#translatedText").html(); | ||
| var cleanMarkedText = rawText.replace(/<span[^>]*id="wordGettingSuggested"[^>]*>/g, mark); | ||
| var cleanMarkedText = cleanMarkedText.replace(/<[/]?span[^>]*>/g, ''); |
There was a problem hiding this comment.
'cleanMarkedText' is already defined no-redeclare
assets/js/translator.js
Outdated
| function getContext(fromWord, wrapLength) { | ||
| var mark = 'MEGAWORD!'; | ||
| var markedWord = mark + fromWord; | ||
| var rawText = $("#translatedText").html(); |
There was a problem hiding this comment.
Strings must use singlequote quotes
Deconflicts #78
|
I don't really know what this does but I'm going to merge it anyway since the suggestions branch will be reviewed fully in the future anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deconflicts #78