Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis actions improvements #336

Merged
merged 2 commits into from
May 10, 2024
Merged

Conversation

tofu-rocketry
Copy link
Member

@tofu-rocketry tofu-rocketry commented May 10, 2024

Remove redundant Python 3 test from Travis as we have working Python 3 tests in GitHub Actions.

Improvements to GH Action unit tests

  • Specify Python versions we're interested in.
  • Add Python version to run name.
  • Add caching.
  • Simplify codecov-action version to major tag.
  • Space out sections.
  • Add comments.

@tofu-rocketry tofu-rocketry added enhancement github_actions Pull requests that update GitHub Actions code labels May 10, 2024
@tofu-rocketry tofu-rocketry added this to the 3.4.1 milestone May 10, 2024
@tofu-rocketry tofu-rocketry self-assigned this May 10, 2024
@tofu-rocketry tofu-rocketry requested a review from a team as a code owner May 10, 2024 12:36
@tofu-rocketry tofu-rocketry changed the title Travis actions Travis actions improvements May 10, 2024
- Specify Python versions we're interested in.
- Add Python version to run name.
- Add caching.
- Simplify codecov-action version to major tag.
- Space out sections.
- Add comments.
Redundant as we have working Python 3 tests in GitHub Actions.
@tofu-rocketry
Copy link
Member Author

tofu-rocketry commented May 10, 2024

Python 3.x test not running will be due to me renaming the tests (and not yet having updated the branch protection rules to match).

The coverage reduction is probably due to Python 3 not exercising some of the code on Travis, which might be the only thing reporting the coverage at the moment.

Copy link
Member

@gregcorbett gregcorbett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tofu-rocketry tofu-rocketry merged commit e3f5c81 into apel:dev May 10, 2024
9 of 10 checks passed
@tofu-rocketry tofu-rocketry deleted the travis-actions branch May 10, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement github_actions Pull requests that update GitHub Actions code
Development

Successfully merging this pull request may close these issues.

2 participants