Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added linting to new shell build script #323

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

Will-Cross1
Copy link
Contributor

Resolved #303

  • Added linting for Debian and rpm in ssm-build.sh

  • Added some dependencies

  • Added a clarification comment to # sudo gem install fpm -v 1.14.2

@Will-Cross1 Will-Cross1 requested a review from a team as a code owner April 17, 2024 09:20
Copy link
Member

@tofu-rocketry tofu-rocketry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just needs a couple of small tweaks.

scripts/ssm-build.sh Outdated Show resolved Hide resolved
scripts/ssm-build.sh Outdated Show resolved Hide resolved
@tofu-rocketry tofu-rocketry self-assigned this Apr 17, 2024
@tofu-rocketry tofu-rocketry added this to the 3.4.1 milestone Apr 17, 2024
scripts/ssm-build.sh Outdated Show resolved Hide resolved
@tofu-rocketry tofu-rocketry force-pushed the 303-add-linting-to-shell-script branch from 8f2d66d to d5e8811 Compare April 17, 2024 12:46
@tofu-rocketry tofu-rocketry merged commit d03c230 into apel:dev Apr 17, 2024
5 of 6 checks passed
@Will-Cross1 Will-Cross1 deleted the 303-add-linting-to-shell-script branch April 17, 2024 12:49
William-Brown5515 pushed a commit to William-Brown5515/ssm that referenced this pull request Nov 20, 2024
…torage-records

[apel#238] Add storage record type for logger
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add linting to new build script
2 participants