-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unroller fix #344
Unroller fix #344
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good to me! I have just a couple questions and a suggestion or two.
tla-pp/src/main/scala/at/forsyte/apalache/tla/pp/ParameterNormalizer.scala
Show resolved
Hide resolved
tla-pp/src/main/scala/at/forsyte/apalache/tla/pp/ParameterNormalizer.scala
Show resolved
Hide resolved
tla-pp/src/main/scala/at/forsyte/apalache/tla/pp/ParameterNormalizer.scala
Outdated
Show resolved
Hide resolved
tla-pp/src/main/scala/at/forsyte/apalache/tla/pp/ParameterNormalizer.scala
Outdated
Show resolved
Hide resolved
tla-pp/src/main/scala/at/forsyte/apalache/tla/pp/ParameterNormalizer.scala
Outdated
Show resolved
Hide resolved
tla-pp/src/main/scala/at/forsyte/apalache/tla/pp/ParameterNormalizer.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. That brings us one step closer to using the new type checker!
tla-pp/src/main/scala/at/forsyte/apalache/tla/pp/ParameterNormalizer.scala
Show resolved
Hide resolved
tla-pp/src/main/scala/at/forsyte/apalache/tla/pp/ParameterNormalizer.scala
Show resolved
Hide resolved
tla-pp/src/main/scala/at/forsyte/apalache/tla/pp/Unroller.scala
Outdated
Show resolved
Hide resolved
* For each recursive operator A the user must define two additional TLA+ operators, | ||
* - [UNROLL_TIMES_PREFIX]_A | ||
* - [UNROLL_DEFAULT_PREFIX]_A | ||
* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this markdown-like commenting work in javadoc? I think you have to use a bit of HTML here, e.g., <p>...</p>
and <ul><li>...</li></ul>
.
closes #129
closes #131
closes #274
closes #309