-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Z3-TurnKey instead of a bespoke Z3 build #219
Conversation
Closes #213 (I hope!)
Also applies auto-formatting
I just finished a clean build on macOS with this branch using Zulu. Here's my configuration:
@istoilkovska, at your convenience, perhaps you could try a clean build off this branch, and see if it works for you as well? I recommend checking out the repo afresh, since this PR changes the 3rdparty libs and the current build configuration doesn't clean up after itself there. Regardless of whether this solves #213, since it reduces the initial build time considerably and simplifies our dependencies and build configuration, and seems to be passing all our tests, I think we'll probably want to keep Z3-TurnKey until #182 is closed as per Z3Prover/z3#182 (comment), by integrating it into Z3 itself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow! This is just amazing. Building z3 has been painful for quite a long time.
@shonfeder I just have merged your PR, as @Kukovec needs it to fix his issue. |
Really cool stuff! I didn't know about z3-turnkey, sounds like it could be very useful for the Scala wrapper we've been developing and using for Stainless/Inox at @epfl-lara. |
I hope that the maintainer of z3-turnkey will keep doing their great work! |
The author is trying to integrate it it into z3, but said they'll continue maintaining in tandem with z3 releases in the meantime: Z3Prover/z3#182 (comment) |
Closes #213 (I hope!)
Our bespoke build and local installation of the Z3 API dependency adds a lot of configuration overhead and brittleness
to our build. While investigating #213, I read about Z3-Turnkey on https://stackoverflow.com/a/62015869/1187277. The purpose of this library is to provide a Java artifact that
I'm hopeful that it can simplify our build overall, and address #213.