Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADR013: Configuration management system #1156

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

shonfeder
Copy link
Contributor

@shonfeder shonfeder commented Dec 6, 2021

This ADR proposes adoption of the PureConfig library for configuration
management. Please see the ADR for details on the proposal.

Towards #1069

  • Ran make fmt-fix (or had formatting run automatically on all files edited)
  • Documentation added for any new functionality

@shonfeder shonfeder requested review from konnov and Kukovec December 6, 2021 20:34
@shonfeder shonfeder mentioned this pull request Dec 6, 2021
2 tasks
Copy link
Collaborator

@konnov konnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! It's a great idea to replace our ad-hoc configuration with a library. PureConfig looks good.

docs/src/adr/013adr-configuration.md Show resolved Hide resolved
Comment on lines 1 to 6
---
authors: Octavia Buttler, Eduardo Galleano
last revised: YYYY-MM-DD
---

# ADR-{NNN}: {Decision Subject}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this template part included in the PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just based this off of the template PR, so I need to rebase.

@shonfeder
Copy link
Contributor Author

Thanks for the fix!

@shonfeder shonfeder force-pushed the shon/1069/adr-012-configuration branch from 57c5ea5 to b418417 Compare December 7, 2021 14:13
@shonfeder shonfeder merged commit ee05a9d into unstable Dec 7, 2021
@shonfeder shonfeder deleted the shon/1069/adr-012-configuration branch December 7, 2021 15:43
@shonfeder shonfeder mentioned this pull request Dec 8, 2021
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants